Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development branch for v2.0.0 #174

Merged
merged 86 commits into from
Nov 13, 2023
Merged

Development branch for v2.0.0 #174

merged 86 commits into from
Nov 13, 2023

Conversation

Pfeil
Copy link
Member

@Pfeil Pfeil commented Nov 10, 2023 •
edited
Loading

  • Merge-ready FAIR DO Lab branch available supporting this version

Notes

  • The strange CI task/action without a name that never ends is a weird artefact that is not defined in the workflow files. I'll ignore it for now. We do not test against Java 11 any more.

Pfeil added 30 commits March 23, 2023 18:37
@Pfeil
TypeRegistry: Make caching self-contained.
93e0602
@Pfeil
Rename typeCache to typeLoader.
0df50be
@Pfeil
Draft of validation strategy pattern.
ecef206
@Pfeil
Use noop validation strategy instead of Optional.
73772df
@Pfeil
Introduce new validation structure to API.
17db03d
@Pfeil
Fix symbol not found.
0e9f494
@Pfeil
Avoid possible NPE in validation helper.
b4a9da9
@Pfeil
Add missing documentation.
ddaf7c3
@Pfeil
Fix assertion order.
1d2b7f7
@Pfeil
Cleanup
882c0a7
@Pfeil
Give test containers some more time.
148e389
@Pfeil
Avoid possible NPE.
e26a8f3
@Pfeil
Remove Lombok from PidRecord.
4f575b7 
This will hopefully give better error messages on code analysis.
@Pfeil
Fix possible NPE.
118e1f6
@Pfeil
Add documentation to validation strategy.
da77d35
@Pfeil
Add tests for unsupported content types.
4a03dea
@Pfeil
HTTP 409 if PID already exists
906cac2
@Pfeil
Add etag method for PIDRecord.
789720a
@Pfeil
Add etag support
aaf6747
@Pfeil
Fix record serialization
de5d394
@Pfeil
Add etag tests
435807f
@Pfeil
Adjust other tests
1c058cc
@Pfeil
Cleanup obsolete exceptions.
14fcecf
@Pfeil
fix(validation): avoid invalid comparison of PIDs
36ede20
@Pfeil
Merge branch 'master' into 114-unclearnon-standard-response-for-post-…
049c5ae 
…apiv1pitpid
@Pfeil
test(docker): Remove docker test for update
078701a 
It is not required anymore due to the extensive unit/integration tests
and would need to be adjusted to make use of etags.
@Pfeil
cleanup: remove unused imports
5b1ff6a
@Pfeil
cleanup: apply some sonarlint suggestions
611d511
@Pfeil
docs(api): adjust error cases to current implementation
8cbe7c0
@Pfeil
feat: send error messages in HTTP reponse headers.
527710a 
Can be disabled using the configuration provided by spring.
@Pfeil
fix: rest endpoints should not start with slashes in spring boot 3
b62c1bf
@Pfeil
fix: Elasticsearch setup
bd845f7 
According to documentation. Not testable at this point.
@Pfeil
docs: show actuator endpoint in swagger
39c4557
@Pfeil
deps: upgrade lombok and jacoco
f97f951
@Pfeil
deps: upgrade springdoc
d923a0d
@Pfeil
fix(test): test body in mockmvc properly.
ff23219 
This was not possible before the update to spring boot 3
for unknown reasons.
@Pfeil
fix: request /known-pids without slash at end
9d9e999
@Pfeil
style: avoid empty lines in function parameter
9cc5d56
@Pfeil
fix(test): enable swagger access without authentication
d84d0b1
@Pfeil
docs: improve docs on diff implementation details
7d77269
@Pfeil
test: handle diff implementation details
92f566b
@Pfeil
build(deps): bump org.springframework.boot to version 3.1.5
5f64149
@Pfeil
build(deps): bump io.freefair.lombok to 8.4 / 1.18.30
ce31193
@Pfeil
build(deps): bump jacoco tool version to 0.8.11
e13cd4a
@Pfeil
build(deps): bump com.google.guava to 32.1.3-jre
428c97b
@Pfeil
fix: elasticsearch repository setup
678da97
@Pfeil
build(deps): update gradle wrapper to version 8.4
86b39ba
@Pfeil
sonarlint: avoid field injection in elastic configuration
ca5aae6
@Pfeil
sonarlint: avoid field injection in web security config
8759250
@Pfeil
chore: remove deprecated functions from web config
06be3dd
@Pfeil
sonarlint: avoid public in tests, if possible.
7c6b317
@Pfeil
Merge pull request #168 from kit-data-manager/115-upgrade-spring-boot
1e403b6 
fix: 115 Upgrade Spring Boot
@Pfeil
Revert "build(deps): update gradle wrapper to version 8.4"
0743e95 
This reverts commit 86b39ba.
@Pfeil
code-analysis: do not use autobuild
eed92c5
@Pfeil
ci: remove explicit push trigger on dev branches
2c33261 
Just open a draft PR to test and track dev branches.
@coveralls
Copy link

Pull Request Test Coverage Report for Build #323

  • 136 of 205 (66.34%) changed or added relevant lines in 14 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+11.8%) to 72.606%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/kit/datamanager/pit/cli/CliTaskBootstrap.java 0 1 0.0%
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/local/LocalPidSystem.java 0 1 0.0%
src/main/java/edu/kit/datamanager/pit/pidsystem/IIdentifierSystem.java 0 2 0.0%
src/main/java/edu/kit/datamanager/pit/web/impl/TypingRESTResourceImpl.java 36 40 90.0%
src/main/java/edu/kit/datamanager/pit/domain/PIDRecord.java 32 37 86.49%
src/main/java/edu/kit/datamanager/pit/domain/SimplePair.java 14 23 60.87%
src/main/java/edu/kit/datamanager/pit/pitservice/impl/TypingService.java 6 17 35.29%
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleProtocolAdapter.java 3 19 15.79%
src/main/java/edu/kit/datamanager/pit/pitservice/impl/EmbeddedStrictValidatorStrategy.java 30 50 60.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/kit/datamanager/pit/pidlog/KnownPid.java 1 95.56%
src/main/java/edu/kit/datamanager/pit/web/impl/TypingRESTResourceImpl.java 1 94.07%
src/main/java/edu/kit/datamanager/pit/pitservice/impl/TypingService.java 2 31.17%
Totals Coverage Status
Change from base Build #292: 11.8%
Covered Lines: 872
Relevant Lines: 1201
💛 - Coveralls

@Pfeil Pfeil marked this pull request as ready for review November 13, 2023 17:20
@Pfeil Pfeil merged commit 3420075 into master Nov 13, 2023
10 checks passed
@Pfeil Pfeil deleted the dev-v2 branch July 31, 2024 13:11
@Pfeil Pfeil restored the dev-v2 branch August 10, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pfeil @coveralls